Code review comment for lp:~thomir-deactivatedaccount/bzr/add-global-config

Revision history for this message
Martin Pool (mbp) wrote :

Thanks for this, Thomi.

+ elif sys.platform.startswith('freebsd'):
+ return osutils.pathjoin(sysconfig.PREFIX, 'etc', 'bazaar')
+ else:
+ return osutils.pathjoin('/etc', "bazaar")

Ideally we would get the whole path to '...etc' from Python, rather than special-casing on the platform.

But I don't actually see anything that points to /etc in sysconfig.get_config_vars() so we might need to either find some other module that tells us where it is, or just hardcode it, in which case I suppose your patch is the best thing.

The docstring also needs to be updated.

« Back to merge proposal