Code review comment for lp:~thomir-deactivatedaccount/bzr/add-global-config

Thanks for working on this !

Did you read http://doc.bazaar.canonical.com/devnotes/configuration.html which describes the current implementation, the stack-based implementation and the steps needed to fully deploy it and then the additional features we want to take into account ? This will probably clarifies some of the issues your encountered so far.

> Things I know still need to be done:
> 1) to consider: rename GlobalStore to UserStore, and SystemGlobalStore to
> GlobalStore. no one outside bzrlib.config and associated unit tests use this
> class directly, so the rename should be trivial.

Two remarks:
1 - No one use them because these classes are there to help the transition to stack based configs which is not finished yet.
2 - GlobalStore is targeted at bazaar.conf, UserStore will probably use user.conf and SystemStore may use /etc/bazaar.conf or whatever we decide.

I didn't introduce the system-wide config file because I wanted to minimize the migration issues (section names, section matching, etc), see the Compatibility section in the URL above.

>
> 2) Test new windows path function.
>
> 3) System-wide config file path for Mac OS X? Haven't found any portable way
> to work out where this should go. Do macs have /etc/?