Code review comment for lp:~thomir-deactivatedaccount/bzr/add-global-config

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

> So I'm just trying to test this interactively, and it's not obviously hooking
> in to the things I might like to configure, such as locks.steal_dead,
> debug_flags, 'config --scope global' etc. Perhaps we should merge it and hook
> it up later? I would be reluctant to actually document this as a new feature
> until it's at least mostly working.

The last time I checked the only config option that used the new stack-based API was the "editor" option.

Unfortunately I've been busy with work & real life, but I intend to get back to this at some point in the future. However, I'm not totally clear on what the future direction is, so if you're happy with the code as-is, the best option might be to merge and work from there.

Cheers,

« Back to merge proposal