Code review comment for lp:~thomir-deactivatedaccount/bzr/add-global-config

Revision history for this message
Martin Pool (mbp) wrote :

I'd really like to get this feature in, and to not have this work stalled.

Vincent's away at the moment, but what do you think, Thomi, do you want to have a go at those changes suggested by Vincent or should someone pick it up?

> It introduces one more config file that will be accessed for each option query (http://pad.lv/832042).

That bug's important to fix, but I don't think it needs to strictly serialize landing this. Reading a global file will make the penalty for multiple lookups linearly worse, but hopefully it doesn't block it entirely.

> It introduces a new file with a semantic which is not the one we want (regarding section filtering/ordering http://pad.lv/832046).

Right, but again it doesn't seem wrong so much as just not yet fixing things we'd like to fix in existing files.

> It doesn't address the defaults/overrides distinction we want to add there (which will require two distinct files, adding another queried config file for each option)

I'm not sure I understand that. Is this to say you want one global configuration that is a low priority, and another that overrides everything else?

« Back to merge proposal