Code review comment for lp:~thumper/launchpad/bug-branch-proposal-view

Trying the prerequisite branch bit.

This branch shows more merge proposal details on the branch page.

 browser/branch.py | 1

Drive by pep-8 cleanup

 browser/branchmergeproposal.py | 20 ++++++

Define a title for the status link based on the approver/rejecter.

 browser/configure.zcml | 15 +++--

New view, and renamed an old one to be more consistent.

 browser/tests/test_branchmergeproposal.py | 72 +++++++++++++++++++------

Cleaned up a test before I realised it was the wrong one.
Added a test for the status title in the view above.

 model/branchmergeproposal.py | 17 +++--

This change is just adding the ability to pass the review date through to the function for better testing.

 stories/branches/xx-branch-merge-proposals.txt | 67 +++++++++++++----------

Move some object creation out into a helper function.
Change the explicit BMP urls to use a recorded value.
Add a section at the end to show how merge proposals look on branch pages.

 templates/branch-index.pt | 4 +

Some page based styles.

 templates/branch-pending-merges.pt | 1

Add in the vote summary.

 templates/branchmergeproposal-link-summary.pt | 3 -

Add the title to the status anchor.

 templates/branchmergeproposal-vote-summary.pt | 49 +++++++++++++++++

Render the details.

 tests/helpers.py | 42 ++++++++++++++

Create some standard people/projects for the tests.
 11 files changed, 234 insertions(+), 57 deletions(-)

This branch only has the change on the branch page, but I'm expecting to have it on the bug page as well in a follow on branch.