Code review comment for lp:~thumper/launchpad/code-email-permissions

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Yes, seems fine. I'm not entirely sure this bit:

25 + The permission check needs to fall through from the owner, that is why
26 + we are using a non-reviewer for this test.

makes complete sense, can you expand it a bit?

Thanks for doing this and cooking up the test though :-)

review: Approve

« Back to merge proposal