Code review comment for lp:~thumper/launchpad/diff-tales

Revision history for this message
Stuart Bishop (stub) wrote :

All the new code looks good.

I find it worrying we are munging HTML rather than munging strings before we generate the HTML (break_long_words), and that the method name doesn't indicate it accepts HTML input rather than plain text. But this is old code.

review: Approve

« Back to merge proposal