Code review comment for lp:~thumper/launchpad/fix-date-review-requested

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I think it looks basically fine, and it must be nice to have found it :)

I wonder if 'sort_key' would be a better name than 'sort_order'?

It's wasn't completely obvious to me that sort_order will not return None all the time -- can you add a comment saying something like "because only approved or ready for review proposals are in the list this always returns non-None". Except more grammatically.

« Back to merge proposal