Code review comment for lp:~thumper/launchpad/fix-review-comment-field-enablement

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Tue, Dec 15, 2009 at 09:24:19AM -0000, Tim Penhey wrote:
> On Tue, 15 Dec 2009 21:16:16 Björn Tillenius wrote:
> > Review: Abstain subscribe
> > I suspect that Windmill isn't the right place to test this, since it's a
> > bit of a corner case.
> >
> > Have you looked into writing a Javascript unit test for this functionality?
>
> At this stage, I'd suggest landing this one line fix, and writing the test
> later.

I agree. Let's get this landed now, so that we'll have more time to QA
it. We do have tests to make sure that commenting and voting on merge
proposals still work.

    vote approve code

review: Approve (code)

« Back to merge proposal