Code review comment for lp:~thumper/launchpad/fix-vocab-oops
Revision history for this message
| Tim Penhey (thumper) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Wed, 28 Oct 2009 17:56:46 Michael Hudson wrote:
> The problem with this is that it will mask genuine problems in our code.
> Not voting for now, will have a think in the morning.
The only place this is being caught is in the place where it is being called
from search. The search method is only called from the BranchVocabulary.
The normal branch traversal stuff still uses the normal method and still
exposes the exceptions.
Tim