Code review comment for lp:~thumper/launchpad/fix-vocab-oops
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> On Wed, 28 Oct 2009 17:56:46 Michael Hudson wrote:
> > The problem with this is that it will mask genuine problems in our code.
> > Not voting for now, will have a think in the morning.
>
> The only place this is being caught is in the place where it is being called
> from search. The search method is only called from the BranchVocabulary.
As discussed on IRC, I'd be happier if you put the try:except: into getByUrl -- that would protect the other callers of this function too. Even happier if you listed the exceptions that can be triggered by dodgy input, but I won't insist.