Code review comment for lp:~thumper/launchpad/kill-bad-form-preloads

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

We discussed on IRC. It's annoying that this isn't tested, but a windmill test would be overkill. Alternatives won't help enough to carry their weight.

Rockstar came up with a good suggestion for the longer term: the login check should happen inside the widget.

review: Approve (js)

« Back to merge proposal