Code review comment for lp:~thumper/launchpad/less-wip-emails

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Looks good. Only the slightest of superficial remarks. To recap from IRC, "there is no email job created" isn't very nice to read; "with person_logged_in(...)" would probably make a few tests a bit cleaner; the final condition in the IStore.find() isn't sufficiently indented.

review: Approve (code)

« Back to merge proposal