Code review comment for lp:~thumper/launchpad/log-diffstat-error-and-continue

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Two minor points:

+ info = sys.exc_info()
+ getUtility(IErrorReportingUtility).raising(info)

Why not just say getUtility(IErrorReportingUtility).raising(sys.exc_info())?

+ # If the diffstat isn't real, we want to record an oops but continue.

This comment isn't very clear. Maybe:

# If the diff is formatted such that generating the diffstat fails, we want to record
# an oops but continue.

?

review: Approve

« Back to merge proposal