Code review comment for lp:~thumper/launchpad/new-code-import-email-show-type
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Tim,
Yay for this :)
Two comments:
I think "CVS" would be better than "Concurrent Versions System" in the email and "Subversion" better than "Subversion via bzr-svn". For the former, one could even change the title of the enum, although that will break some tests.
The second point is much simpler: there is too much vertical whitespace at the end of the test file :)
But in general, very happy to see this move.
Cheers,
mwh