Code review comment for lp:~thumper/launchpad/revisions-in-conversation

Revision history for this message
Curtis Hovey (sinzui) wrote :

This is very nice. I have no remarks about your code. SO I read it again and to see if I missed something. I still had no remarks about your code. So I think this is fine to land.

There are two spelling mistakes in code you changed. You can correct these if you wish.

> === modified file 'lib/lp/code/doc/branch.txt'
> --- lib/lp/code/doc/branch.txt 2009-08-02 23:59:31 +0000
> +++ lib/lp/code/doc/branch.txt 2009-12-10 01:54:21 +0000
> @@ -426,14 +426,14 @@
> >>> list(junk.latest_revisions(3)) == three_latest
> True
>
> -Branch.revisions_since gives all the BranchRevisions for revisions comitted
> +Branch.getRevisionsSince gives all the BranchRevisions for revisions comitted
> since a given timestamp. It may give suprising results if some committers had a

grammar: s/comitted/committed/
grammar: s/suprising/surprising/

review: Approve (code)

« Back to merge proposal