Code review comment for lp:~thumper/launchpad/xmlrpc-lp-name-resolution

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hi,

I'm a bit confused about the whole supported_schemes stuff, it seems overly hairy. But it's not new.

The docstring of assertRaises has become a bit garbled, can you have a proof read and fix it up?

Do we have a codehosting acceptance test that accesses a branch by its lp: urls? Maybe we should.

Otherwise all fine. People will be very happy about this :-)

Cheers,
mwh

review: Approve

« Back to merge proposal