Code review comment for lp:~tobijk/livecd-rootfs/image-sets
Revision history for this message
| Tobias Koch (tobijk) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
@vorlon, thank you so much for taking the time to review this in depth!
* There is now also a series file for the qcow2 target.
* It turned out that copying resources was not even necessary, because all scripts except one reference resources relative to their location. So I have removed that part completely.
I would like to keep the series file for the chroot, because:
* I find it more consistent to have all hooks placed/generated in the same way in the CPC subproject.
* We will want to augment the syntax of the series files in the future to also take into account arch, subarch and other attributes of the build that are currently handled by case statements in the scripts and this can also be useful for chroot customization,
* This is not on the table, right now, but I can imagine that we will find it useful to drop the ability to build different image target sets together and do per target set (and arch) chroot customizations. There can be advantages to this such being able to seed all target specific packages and snaps into the chroot instead of having to mount, fiddle and re-sparsen an image.