Code review comment for lp:~txamqpteam/txamqp/support-basic-return

Revision history for this message
Terry Jones (terrycojones) wrote :

Hi Dan

>>>>> "Dan" == Dan Di Spaltro <email address hidden> writes:
Dan> Ran the code works well, very handy to boot, now our services are more
Dan> reliable. The log stuff could probably be cleaned up a bit and lines
Dan> shortened but that is just cosmetic.

The logging in src/txamqp/contrib/thrift/client.py (if that's what you were
referring to) is there due to very the occasional absence of 'headers' in
msg.content. I've seen it happen a couple of times, and had it in
reproducible form (though in the complex setup that is FluidDB, so not easy
to reduce and post for others). But I've not had time to look at it. So I
left the logging there in the hope that someone else might see this pop up
and feel like digging into it :-) I'm sure I will at some point.

It may be benign / harmless. Esteve, I think, came up with a scenario in
which this might happen, but I forget the details.

Terry

« Back to merge proposal