~vcs-imports/gnome-settings-daemon/+git/gnome-settings-daemon:benzea/misc-fixes

Last commit made on 2019-04-16
Get this branch:
git clone -b benzea/misc-fixes https://git.launchpad.net/~vcs-imports/gnome-settings-daemon/+git/gnome-settings-daemon

Branch merges

Branch information

Recent commits

a0525ed... by Benjamin Berg <email address hidden>

color: Disable vendor check in JHBuild

I keep running into the issue that the vendor lookup fails in my jhbuild
environment. This is kind of annoying, and I suspect it may also affect
other people.

Disable the test locally, it will be still be run in the CI environment
so that this shouldn't create corner cases that are missed.

2d08840... by Benjamin Berg <email address hidden>

rfkill: Allow more time for bluetooth devices to initialize

In some corner cases systemd-rfkill may immediately turn of a bluetooth
device that is being added (due to a platform rfkill being unblocked).

Unfortunately the timeout of 500ms is not sufficient of some machines so
increase it to 1s. An example of such a case:

1494941564.350097: idx 0 type 2 op 2 soft 0 hard 0
1494941564.830240: idx 15 type 2 op 0 soft 0 hard 0
1494941564.879854: idx 15 type 2 op 2 soft 1 hard 0

Which is almost 530ms between the platform device being unblocked and
systemd-rfkill blocking the newly appeared rfkill switch.

https://bugzilla.gnome.org/show_bug.cgi?id=782532

4af47a0... by Benjamin Berg <email address hidden>

xsettings: Increase timeout in xsettings test

It seems that this is causing sporadic failures. Increase the sleep time
to apply the settings to 2 seconds rather than only waiting one second.

abdaa8f... by Benjamin Berg <email address hidden>

screensaver-proxy: Fix missing error returns for DBus method calls

Many of the error cases were not handled, resulting in the sender to
never get a reply. Fix these by adding appropriate error return paths
(simply returning a generic GError in some cases).

Fixes: #344

69c781c... by Benjamin Berg <email address hidden>

power: Clarify reason for lid inhibition

The reason was "Multiple displays attached" which is not really
accurate, as we are looking for an external screen rather than multiple
screens. Also, we always grab the inhibitor after a change and then
release it again if there is no external monitor after a short period of
time.

Change it to "External monitor attached or configuration changed
recently" which should clarify this.

Fixes: #353

f93c42b... by Benjamin Berg <email address hidden>

meson: Bump polkit requirement to 0.114

This is needed for the ITS rules, without it msgfmt fails on the policy
file.

Fixes #10

0a6f325... by Benjamin Berg <email address hidden>

meson: Bump colord requirement

We need at least 1.3.5 for cd_color_get_blackbody_rgb.

Fixes #392

c64c243... by Benjamin Berg <email address hidden>

power: Fix parent element of the manager object struct

This is a regression that was introduced when moving to
G_DECLARE_FINAL_TYPE. This was a typo that only happened for
GsdPowerManager, and the other migrated classes are fine.

fb2ca61... by Benjamin Berg <email address hidden>

power,color: Use g_signal_connect_object for the session manager

The session manager object is globally shared and may live longer than
the GSD plugin manager object. Use g_signal_connect_object rathre than
g_signal_connect to prevent callbacks to destroyed objects.

This is a theoretical issue, no impact has been seen from this.

cb2a1c3... by Benjamin Berg <email address hidden>

power: Fix potential manager reference count leak

The reference would be leaked if the function returns early. Move
attaching the data and register it so it gets unref'ed automatically.

Note that this reference leak has no effect in normal sessions, in the
worst case it prevents proper cleaup of some resources on daemon
shutdown.