e7e4b8b...
by
Philip Withnall <email address hidden>
rfkill: Fix use of deprecated g_memdup()
It’s been deprecated in GLib 2.68 in favour of `g_memdup2()`, which uses
correct argument types so as not to silently cause an overflow during an
implicit integer size conversion.
The existing code was safe and correct: this commit just fixes the
deprecation warning.
Signed-off-by: Philip Withnall <email address hidden>
8993854...
by
Philip Withnall <email address hidden>
power: Fix exit status checking for the backlight helper program
`g_spawn_check_exit_status()` operates on a *wait status* rather than an
*exit status*. A wait status is what’s returned by `waitpid()`, and it’s
a platform-specific combination of bits indicating whether the program
exited gracefully, or crashed/signaled, and what value it returned
from `main()` (if any). An exit status is the value returned from
`main()` (so, zero for a successfully-exiting application).
`g_spawn_check_exit_status()` has been deprecated since GLib 2.70
because of its confusing naming.
`g_subprocess_get_exit_status()` returns an exit status (so is named
correctly), but we don’t actually have to use it because `GSubprocess`
already provides an API which combines `g_subprocess_wait_async()` and
`g_spawn_check_wait_status()`: `g_subprocess_wait_check_async()`.
So just use that instead. It’s been available since GLib 2.40.
Signed-off-by: Philip Withnall <email address hidden>
aab5fd4...
by
Philip Withnall <email address hidden>
color/datetime: Use updated GTimeZone API from GLib
`g_time_zone_new()` was deprecated in GLib 2.68 because its error
handling behaviour was poorly defined. `g_time_zone_new_identifier()` is
equivalent but with better-defined error handling. Use that.
Since the timezone identifier in the `datetime` plugin notification is
coming from a system component, I assume it’s going to exist, hence the
use of `g_warning()` for error handling rather than anything more
involved.
Signed-off-by: Philip Withnall <email address hidden>
1c6a7e5...
by
Philip Withnall <email address hidden>
housekeeping: Stop using deprecated non-Y2038-safe time APIs
Use `GDateTime` instead of `GTimeVal`. This requires bumping the GLib
dependency to 2.70 so we can use some `GFileInfo` convenience functions
(the same changes would be possible, but more complex, without bumping
the dependency). Debian Stable is currently shipping GLib 2.74, so 2.70
should be widely available.
This makes the housekeeping code Y2038-safe.
Signed-off-by: Philip Withnall <email address hidden>
b8c297b...
by
Philip Withnall <email address hidden>
build: Bump minimum GLib dependency to 2.64
It’s needed for `g_warning_once()`, as used in the media-keys plugin
since January 2023.
Debian Stable currently ships GLib 2.74, so 2.64 should be very widely
available by now.
This fixes the following compiler warnings:
```
../../source/gnome-settings-daemon/plugins/media-keys/gsd-media-keys-manager.c: In function ‘do_config_power_button_action’:
../../source/gnome-settings-daemon/plugins/media-keys/gsd-media-keys-manager.c:2047:13: error: Not available before 2.64 [-Werror]
2047 | g_warning_once ("Virtual machines only honor the 'nothing' power-button-action, and will shutdown otherwise");
| ^ ~~~~~~~~~~~~~~~~~~~~~~~
../../source/gnome-settings-daemon/plugins/media-keys/gsd-media-keys-manager.c:2067:13: error: Not available before 2.60 [-Werror]
2067 | G_GNUC_FALLTHROUGH;
| ^ ~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
```
Signed-off-by: Philip Withnall <email address hidden>
84a95a1...
by
Philip Withnall <email address hidden>
build: Fix use of deprecated Meson path APIs
These were deprecated in Meson 0.56 in favour of replacements which
allow differentiating between the current project and the parent project
when being used as a subproject.
Signed-off-by: Philip Withnall <email address hidden>
994ca29...
by
Philip Withnall <email address hidden>
build: Fix use of deprecated Meson pkgconfig API
Using `dep.get_pkgconfig_variable()` has been deprecated since Meson
0.56, but gnome-settings-daemon depends on 0.57.
Signed-off-by: Philip Withnall <email address hidden>
e755ec7...
by
=?utf-8?q?Pablo_Correa_G=C3=B3mez?= <email address hidden>
meson: use systemd option to decide whether dependencies are required
This is a small simplification, and allows to build against elogind
without patches
