Code review comment for lp:~vila/bzr-gtk/388790-windows-setup

Revision history for this message
Vincent Ladeuil (vila) wrote :

> Yes, that's correct, sys.path manipulations needed only for bzr.exe. This
> approach assumes that all extra libs required for <email address hidden> is placed in
> _lib subdirectory inside directory where plugin resides.

Oh my, I understand the intent now :-(
So that's really a workaround waiting for a better windows packaging that can provide
the needed gtk libraries, I'll add a comment to clarify that.

>
> And:
>
> #sys.path.append(here)
>
> ^-- yep, you really don't need this append. I dunno why it was there.

Ok. Good.

« Back to merge proposal