Code review comment for lp:~vila/bzr-gtk/388790-windows-setup

Vincent Ladeuil пишет:
>> Yes, that's correct, sys.path manipulations needed only for bzr.exe. This
>> approach assumes that all extra libs required for <email address hidden> is placed in
>> _lib subdirectory inside directory where plugin resides.
>
> Oh my, I understand the intent now :-(

And why it makes you sad? We did this for QBzr for couple of years long
before QBzr was accepted to be a part of TortoiseBzr and therefore
starting bundled into bzr.exe installer.

> So that's really a workaround waiting for a better windows packaging that can provide
> the needed gtk libraries, I'll add a comment to clarify that.

To be clear, yes, this is workaround, and it required not only for
bzr-gtk. But for bzr-git as well, and many other plugins which dare to
use some extra libs. This is how py2exe worked. There is nothing special
about bzr-gtk. We all in the same boat.

But please, don't start the thread about "bzr.exe must die". Pretty please.

__________ Information from ESET NOD32 Antivirus, version of virus signature database 4469 (20090930) __________

The message was checked by ESET NOD32 Antivirus.

http://www.esetnod32.ru