Code review comment for lp:~vila/bzr-gtk/388790-windows-setup

Revision history for this message
GuilhemBichot (guilhem-bichot) wrote :

Vladislav Vaintroub my colleague and me confirm that the patch works. I branched Vincent's bzr-gtk branch into my plugins directory, also put there (inside bzr-gtk) the _lib directory found in Kevin Light's package (available at http://bazaar-vcs.org/bzr-gtk?action=show&redirect=BzrGtk), and then gannotate/viz/gcommit work.
Vincent: about what your patch does. We had observed that when using the standalone bzr Windows installer, bzr-gtk cannot find pygtk (even though pygtk is properly installed). Looks like that version of bzr cannot look for modules out of certain predefined places. Kevin Light's solution is
1) to bundle pygtk and other modules in one directory (makes a quicker install than installing pygtk, pygobject, etc etc)
2) to instruct bzr to look into that directory (which is done through a patch to bzr-gtk adding the directory to the search path).
He created a patched version of bzr-gtk available at http://bazaar-vcs.org/bzr-gtk?action=show&redirect=BzrGtk, but that is based on bzr-gtk 0.96. And it's annoying to have to use the old 0.96 for us.
With your patch, we can use Kevin's approach (put a _lib directory when you install) but without using 0.96: we can do it with the bzr-gtk dev branch, which is better.

« Back to merge proposal