Code review comment for lp:~vila/bzr/2.2-693880-ssl-readline

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/24/2010 11:22 AM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/2.2-693880-ssl-readline into lp:bzr/2.2.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/2.2-693880-ssl-readline/+merge/44671
>
> Bug #693880 broke the workaround describe in the patch (I won't copy it here :).
>
> This came with the dev version that recently landed in natty.
>
> Long story short, this is somewhat critical as it breaks https access, so the sooner we land it the better.
>
> Since the patch is small, I targeted 2.2 so we won't have to backport in a hurry if people upgrade to python2.7 while using a stable version, but I think we may have released 2.3 when the corresponding change is released in python.
>
> The most likely to encounter this problem are early natty adopters, so I'll make sure this get included in 2.3b5 asap and may release it on 2011-01-06 as previously planned.
>
> I've tested this fix on babune again python 2.4, 2.5 and 2.7 and locally on 2.6.

It is only missing a comment on why the version check has to exist. (on
version X size is not accepted, in version Y size is being passed by
default.)

Other than that:

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0iMVoACgkQJdeBCYSNAAMlCACg0J1xjHAittp9QhjqiZTkTfoE
5KwAoKfyTKWeTzSrzaaj2O1cFNkIU193
=rrZm
-----END PGP SIGNATURE-----