Code review comment for lp:~vila/bzr/323111-orphan-config-option

On 17 September 2010 18:01, Andrew Bennetts
<email address hidden> wrote:
> Martin Pool wrote:
> [...]
>> I think the always/never distinction is not the right dimension though,
>> because it seems to assume there is one thing that we want to have either on
>> or off.  But I think what we want is, well, actually different policies, which
>> might include:
>>
>>  * conflict: mark the directory conflicted and don't remove it
>>  * unversion: mark the containing directory unversioned, but leave it in the tree
>>  * move: move them to a bzr-orphans directory in the root of the tree
>>  * delete: just immediately delete them
>
> This is a great way to put it, that's what I was thinking too.
>
> For example, I'm imagining plugins adding support for:
>
> orphans = vary_by_file_ext
> orphan_policies = pyc:delete,*:move
>
> (as a not very carefully designed strawman...)

Mm, or better I'd like to see the rules file group them in to classes
of 'precious', 'junk', etc, then perhaps different orphan policies
depending on class.
--
Martin