Code review comment for lp:~vila/bzr/353370-notty-no-term-width

2009/12/5 Vincent Ladeuil <email address hidden>:
>>>>>> "martin" == Martin Pool <email address hidden> writes:
>
>    martin> I think this is ok to land as it is, but eventually the priority we want is
>    martin> 1- BZR_COLUMNS
>    martin> 2- TIOCGWINSZ if possible (or the equivalent for win32)
>    martin> 3- COLUMNS otherwise
>    martin> 4- otherwise None
>
> Damn, I didn't notice that earlier.
>
> Well, I tried that but that's wrong, at least under emacs. That
> means at least in one case COLUMNS is more correct than
> TIOCGWINSZ (I *think* the rationale is that you can have COLUMNS
> smaller than the window size because you use only part of that
> window or bigger because the window has scroll bars).

Is this emacs in its own frame, or emacs inside a termal?

If you run bzr inside a terminal and then resize it while bzr is
running, $COLUMNS does not change. (I am assuming the fcntl will give
you the right result.)

Anyhow, this is still a step forward.

--
Martin <http://launchpad.net/~mbp/>