Code review comment for lp:~vila/bzr/533547-dsrt-kind

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/533547-dsrt-kind into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #533547 OOPS-ID-1526appserver102557
> https://bugs.launchpad.net/bugs/533547
>
>
> Drive-by fix encountered while working on bug #531967.
>
> That revealed a hole in our test coverage that I won't investigate further than the added test.
>
> The consequences of this bug are unclear as we usually use only the basis tree
> (which explain why the bug remained unnoticed).
>

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuX4xsACgkQJdeBCYSNAANTmQCeIYKNANyufwbTBcE190hU29L0
DBUAoKrpMCxKCDMcuf6/cBlGnkMnwPif
=fj9/
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal