>>>>> John A Meinel <email address hidden> writes:
> This looks like it contains code that I've already reviewed.
Really ? I don't have any trace of such a review... Did you approve it ?
:-D
> It has the [.../tree] sections, which seems unrelated.
It *is* related as mentioned in the news entry (and the commit message):
``bzr config`` will now respect option policies when displaying the
value and display the definition sections when appropriate.
While fixing this bug I realized I didn't have tests where the same
option was defined in several section in the same config file which
requires displaying the section name. The lines you're referring to are
a fallout.
> Are we sure it isn't a second submission of the same code?
Are you sure you didn't read it in the commit ML instead ?
I remember a discussion though, so may be it was on IRC and you didn't
put your comments in the mp (can't find it though) ?
>>>>> John A Meinel <email address hidden> writes:
> This looks like it contains code that I've already reviewed.
Really ? I don't have any trace of such a review... Did you approve it ?
:-D
> It has the [.../tree] sections, which seems unrelated.
It *is* related as mentioned in the news entry (and the commit message):
``bzr config`` will now respect option policies when displaying the
value and display the definition sections when appropriate.
While fixing this bug I realized I didn't have tests where the same
option was defined in several section in the same config file which
requires displaying the section name. The lines you're referring to are
a fallout.
> Are we sure it isn't a second submission of the same code?
Are you sure you didn't read it in the commit ML instead ?
I remember a discussion though, so may be it was on IRC and you didn't
put your comments in the mp (can't find it though) ?