Code review comment for lp:~vila/bzr/671050-config-policy

Revision history for this message
Martin Pool (mbp) wrote :

That looks reasonable. The comment you add:

+ # Display only the first value and exit (We need to use
+ # get_user_option to take policies into account and we need
+ # to make sure the option exists too :-/)
+ self.outf.write('%s\n' % c.get_user_option(name))

makes me wonder if it should have an XXX, especially the emoticon? Or is there just missing punctuation and could be a little clearer?

review: Approve

« Back to merge proposal