Code review comment for lp:~vila/bzr/688072-skip-sphinx-failures

Revision history for this message
Vincent Ladeuil (vila) wrote :

> + return tuple(features.sphinx.module.__version__.split('.'))
> +
>
>
> ^- I'm pretty sure that isn't enough, since '12' < '6'.

Doh ! Thanks, fixed.

> I'm fine with this, though not supporting maverick is a bit odd.

(0, 6, 6) < (1,0) so we support maverick. Keep in mind though, that's the texinfo version needs work for all the intra and extra links anyway.

« Back to merge proposal