Code review comment for lp:~vila/bzr/cleanup

Revision history for this message
John A Meinel (jameinel) wrote :

There is a small regression in osutils, in that it will force-loading of 'shutil' always, rather than only when someone calls 'shutil.rmtree'.

I also have some gripes about test_http being hard to understand (it made it difficult to understand why this patch was ok). However I filed a bug on that (bug #597791) and doesn't need to block this patch.

So 'tweak', and land with a small fix to osutils.

review: Needs Fixing

« Back to merge proposal