Code review comment for lp:~vila/bzr/freebsd-regressions

Revision history for this message
Matthew Fuller (fullermd) wrote :

> - elif sys.platform == 'darwin':
> - # OS X creates temp dirs with the 'wheel' group, which users are
> - # not likely to be in, and this prevents us from setting the sgid
> - # bit
> + elif sys.platform == 'darwin' or sys.platform.startswith('freebsd'):
> + # OS X (and FreeBSD) create temp dirs with the 'wheel' group, which
> + # users are not likely to be in, and this prevents us from setting
> + # the sgid bit

This and the other similar one will apply to anything with BSD-derived
filesystem semantics. BSD FSen always inherit the group from the
parent directory (rather than only when the dir is sgid like SysV).
So this will presumably affect Net/Open/Dragonfly/whatever else too,
and maybe others (earlier versions of HP/UX? Like we even support
that... ;)

However, it can vary by filesystem too. On ZFS, for instance, SysV
semantics hold.

--
Matthew Fuller (MF4839) | <email address hidden>
Systems/Network Administrator | http://www.over-yonder.net/~fullermd/
           On the Internet, nobody can hear you scream.

« Back to merge proposal