Bazaar

Code review comment for lp:~vila/bzr/move-test-servers

  1. move-test-servers
  2. Merge into bzr.dev
Revision history for this message
John A Meinel (jameinel) wrote :

This change looks ok except:

1) I expect it will cause some significant fallout with Launchpad and possibly some plugins.
2) We should make sure to have a nice big NEWS entry about how to update your code. It looks mostly like just importing 'test_server' and using whatever server you were using previously. (I would expect MemoryServer to be the only one causing problems.)

I wonder if we should just leave in a deprecated thunk for MemoryServer...

3) We should probably try to coordinate with someone like MWH for (1).

review: Approve

« Back to merge proposal