Code review comment for lp:~vila/bzr/webdav-in-core
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> > In general, I like the idea of shipping the webdav plugin.
> >
> > Wouldn't it make sense to merge some (all?) of this code into the HTTP
> > implementation? I don't see a particular reason why WebDAV support couldn't
> be
> > in the default HTTP implementation.
>
> 'default' is the key word here, the very webdav implementation was against
> pycurl but it couldn't be completed (if my memory serves me well).
Speaking of which - this code seems to be based on urllib, but it still uses raise_curl_error ?
> > That said, I don't think this integration should be a blocker for merging
> > the webdav plugin into core. Let's move it one step at a time. :-)
> Cool, I'm not sure how to interpret this a vote though ;)
I haven't done a thorough review of the code yet, was mostly saying that I agree with merging this in principle.