Code review comment for lp:~vila/bzr/webdav-in-core

Revision history for this message
Vincent Ladeuil (vila) wrote :

> > 'default' is the key word here, the very webdav implementation was against
> > pycurl but it couldn't be completed (if my memory serves me well).
> Speaking of which - this code seems to be based on urllib, but it still uses
> raise_curl_error ?

Bah, who mentioned coverage as a criteria to accept plugins in core ? :-}

>
> > > That said, I don't think this integration should be a blocker for merging
> > > the webdav plugin into core. Let's move it one step at a time. :-)
> > Cool, I'm not sure how to interpret this a vote though ;)
> I haven't done a thorough review of the code yet, was mostly saying that I
> agree with merging this in principle.

Ok, thanks.

« Back to merge proposal