Code review comment for lp:~vila/qbzr/config-get-filename-deleted

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Thanks for the patch.

I did a user test with both 2.2 and bzr.dev, and it works for both.

But when I run the test suit with 2.2, I get this error, in 5 different tests: (I don't get the errors when I run the test suit with bzr.dev)
======================================================================
ERROR: bzrlib.plugins.qbzr.lib.tests.test_log.TestLog.test_just_show_log_simple_commit
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/garyvdm/qbzr/trunk/lib/util.py", line 334, in closeEvent
    self.saveSize()
  File "/home/garyvdm/qbzr/trunk/lib/util.py", line 282, in saveSize
    config.set_user_option(name + "_window_size", "%dx%d" % size)
  File "/home/garyvdm/qbzr/trunk/lib/util.py", line 228, in set_user_option
    self._write_config_file()
  File "/usr/lib/python2.6/dist-packages/bzrlib/config.py", line 483, in _write_config_file
    atomic_file = atomicfile.AtomicFile(filename)
  File "/usr/lib/python2.6/dist-packages/bzrlib/atomicfile.py", line 75, in __init__
    self._fd = os.open(self.tmpfilename, flags, local_mode)
OSError: [Errno 2] No such file or directory: '/tmp/testbzr-oUnF5j.tmp/bzrlib.plugins.qbzr.lib.tests.test_log.TestLog.test_just_show_log_simple_commit/home/.bazaar/qbzr.conf.7129.garyvdm-desktop.di9b8xq1o1.tmp'

----------------------------------------------------------------------

I'll have to take a look why after work today.

review: Needs Fixing

« Back to merge proposal