Code review comment for lp:~wallyworld/launchpad/log-sql-bind-variables

Revision history for this message
Robert Collins (lifeless) wrote :

Couple of small tweaks.

Looking at storm, you probably want to replace
     param_strings = [
40 + (lambda x:
41 + x.get() if isinstance(x, Variable) else str(x))(p)
42 + for p in params]

with

param_strings = Connection.to_database(params)

which will change get() to get(to_db=True) as well as being more pithy.

This may fix your test issue, though there is an obvious open question of 'why is it failing' - and the problem is - I don't know (other than that there are apparently test failures in trunk (eep)).

« Back to merge proposal