Code review comment for lp:~wallyworld/launchpad/recipe-find-related-branches

On Thu, 2011-01-27 at 12:57 +0000, Ian Booth wrote:
[...]
> > I thought the text area widgets were constrained by the width of the
> > surrounding elements, but I was wrong; zope's TextAreaWidget uses, by default,
> > a 60-cols width. I'd also prefer if the tables had the same width as the
> > other form elements, but I'm not sure using a fixed width on the table is a
> > good idea because the widget's width might change but most importantly because
> > I don't think the fixed-width table will behave the same way as the textare
> > widget when the window is resized to a smaller size than what's needed to fit
> > the textarea.
>
> Before doing the fixed width tables, I did check the behaviour of the
> widgets' layouts when the browser window was resized and it all
> behaved as expected - the text area widget and tables retained their
> width and a simple horizontal scroll bar was added to the browser
> window.

I thought the number of columns on a textarea wouldn't prevent the
browser from resizing it when the window is resized. That's the
behaviour I see with the comment box (which specifies cols=60) on a
merge-proposal page, but I tested here on a html file I crafted and the
browser didn't resize my textarea. Maybe Curtis will know why we're
seeing a different behaviour on the merge-proposal page.

>
> What I've done now is to make the <fieldset> element which contains
> everything for the related branches widget a fixed size and remove the
> width styling from the tables. The resize behaviour is the same as
> described above but I think it's a cleaner implementation.

Do you really think we should go with the fixed width, even with all its
drawbacks?