Code review comment for lp:~wallyworld/launchpad/recipe-find-related-branches

Revision history for this message
Ian Booth (wallyworld) wrote :

I think that if we limit the results, the user should be informed, lest
they get confused as to why a branch they may have been expecting to be
there is not. But that's just my opinion as a general ui priciple. If
you feel it's better to remove the text, that's no problem. Or would a
rewording of the text be better?

On 31/01/11 12:28, Tim Penhey wrote:
> On Mon, 31 Jan 2011 15:18:53 you wrote:
>> I added functionality to limit the number of related branches displayed to
>> 5 in each category. See screenshot for example of how it looks:
>>
>> http://people.canonical.com/~ianb/recipe-related-branches3.png
>>
>> The branches shown are the most recent according to the
>> sorted_version_numbers() function: - for related series, branches, the
>> ordering is applied to the product series, and the devel focus is always
>> shown - for package branches, the ordering is applied to the distro series
>
> I don't think it is beneficial to have the text: "Top 5 most recent
> branches...".
>

« Back to merge proposal