Code review comment for lp:~wallyworld/launchpad/recipe-webservice-api

Revision history for this message
Ian Booth (wallyworld) wrote :

> requestBuild is a classic case of a named operation, but there's no reason to
> publish the others as named operations.
> They don't change the dataset and they don't take any arguments. Let's publish
> them as scoped collections and keep our public API cleaner:
>
> recipes
> builds
> completed_builds
> pending_builds
>
> And a link:
>
> last_build
>

Hi Leonard,

I have converted the getter methods to be properties as discussed. Tests pass and running up an instance locally works fine too. I ran some additional tests: test_person, test_hasrecipes, test_request_daily_builds, since these were changed as part of the conversion to using properties.

« Back to merge proposal