Code review comment for lp:~wallyworld/launchpad/recipe-webservice-api

Revision history for this message
Robert Collins (lifeless) wrote :

On Thu, Feb 24, 2011 at 2:18 AM, Leonard Richardson
<email address hidden> wrote:
> Review: Approve
> This looks great now. My only comment is that  "sorted by 'desc(date_created), then by desc(id).'" is a bad way to describe a field. This description will be going into the HTML documentation at https://launchpad.net/+apidoc/devel.html, so you should say something understandable by external developers. Something like "Sorted in descending order of creation."

An interesting thing about phrasing it like that, is that it makes it
obvious that the sort is inefficient: better to just sort on Desc(id)
- that is precisely the same sort because ids are allocated
sequentially, and under half the work for the DB.

« Back to merge proposal