Code review comment for lp:~wallyworld/launchpad/tales-linkify-broken-links

Revision history for this message
Tim Penhey (thumper) wrote :

Getting pretty close now...

> if len(error_msg)==0:

PEP-8 says spaces either side of the operator, although I think

  if error_msg == '':

Is more obvious.

The _validateNotificationContext has a extra blank lines it doesn't need.
You can set the linked branch when you are making a series with the factory
using branch=...

Setting the development focus should be:
  ICanHasLinkedBranch(product).setBranch(...)

review: Needs Fixing

« Back to merge proposal