Code review comment for lp:~wallyworld/launchpad/tales-linkify-broken-links

Revision history for this message
Ian Booth (wallyworld) wrote :

>
> The _validateNotificationContext has a extra blank lines it doesn't need.

Sometimes I like to leave blank lines to aid readability, although the
following one should go:

+ self.assertEqual(len(notifications), 1)
+ self.assertEquals(notifications[0].level, level)
+
+ self.assertEqual(notification, notifications[0].message)

I can remove the others as well.

> You can set the linked branch when you are making a series with the factory
> using branch=...
>

I don't know about that, unless I am missing something :-)

lp.testing.factory.py:
    def makeProductSeries(self, product=None, name=None, owner=None,
                          summary=None, date_created=None):
        """Create and return a new ProductSeries."""

There's no named parameter for branch. Hence it complains if one tries
to use branch=.

« Back to merge proposal