Code review comment for lp:~wallyworld/launchpad/tales-linkify-broken-links

Revision history for this message
Ian Booth (wallyworld) wrote :

A usage analysis shows:

215 usages of makeProductSeries
38 usages of makeSeries

There's too many changes to do a simple drive by. I think we should land
this branch as is and then do the consolidation in another branch.

Ok?

On 15/09/10 18:01, Tim Penhey wrote:
> On Wed, 15 Sep 2010 17:25:59 you wrote:
>> lp.testing.factory.py:
>> def makeProductSeries(self, product=None, name=None, owner=None,
>> summary=None, date_created=None):
>> """Create and return a new ProductSeries."""
>>
>> There's no named parameter for branch. Hence it complains if one tries
>> to use branch=.
>
> Found it. It is called makeSeries. Damn. We now have two factory methods to
> do the same thing. Can you please consolidate?

« Back to merge proposal