Code review comment for lp:~wallyworld/launchpad/tales-linkify-broken-links

Revision history for this message
Tim Penhey (thumper) wrote :

Last thing:

   target = ICanHasLinkedBranch(distro_package)
   run_with_login(
       registrant,
       target.setBranch, branch, registrant)

IMO reads more easily as:

    with person_logged_in(registrant):
        ICanHasLinkedBranch(distro_package).setBranch(branch, registrant)

review: Approve

« Back to merge proposal