Code review comment for lp:~wallyworld/launchpad/unassign-private-bug

Revision history for this message
Robert Collins (lifeless) wrote :

This is much cleaner - thanks.

Uhm, its not clear to me why the person unassigning themselves wouldn't get a notification if they would have on a public bug. Is that just the way it works, or deliberate?

Your test doesn't make it clear that the case under test is 'the assignee unassigns *themself* and *can only see the bug due to being assigned to it*. Both those conditions must be true to trigger the fault you are fixing.

If your test already does test this, consider tweaking the explanation in it to make this clear (and why it matters).

review: Approve

« Back to merge proposal