Code review comment for lp:~wallyworld/launchpad/unassign-private-bug

Revision history for this message
Ian Booth (wallyworld) wrote :

>
> Uhm, its not clear to me why the person unassigning themselves wouldn't get a notification if they would have on a public bug. Is that just the way it works, or deliberate?
>

Good question. That's the way it works. It sort of makes sense - once
you are unassigned, the bug is invisible to you since it is private.

> Your test doesn't make it clear that the case under test is 'the assignee unassigns *themself* and *can only see the bug due to being assigned to it*. Both those conditions must be true to trigger the fault you are fixing.
>
> If your test already does test this, consider tweaking the explanation in it to make this clear (and why it matters).

I'll fix the explanation.

« Back to merge proposal