Code review comment for lp:~wallyworld/lazr.restful/propogate-notifications
Revision history for this message
| Ian Booth (wallyworld) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> There are a couple of things that are still needed on this branch.
>
> First, I can't get the tests to pass. First there was an undeclared
> dependency on testtool, so I removed references to it but then I got
> many, many other failures. If you're not seeing these, then I suspect
> you're running the tests with a dirty Python (e.g., a system Python).
> Running with a clean Python (or virtualenv) should result in the same
> failures.
>
testtool is used in tests other than the new one created for this mp. The issue is that it had not been added to the project dependencies in setup.py etc. So I've fixed that and run the tests using virtualenv and they all pass. I had to also remove as a drive-by a bad import that was causing lots of noise in the test run.
Other requested fixes also done.