Looks good to me with the 2 points below fixed. +1
[1]
+ def __init__(self, name, select, **kwargs):
Any particular reason for not writing this as:
+ def __init__(self, name, select, recursive=False):
?
It feels more explicit to me.
[2]
Please document the new recursive parameter in the class docstring, like:
class With(Expr): """Compiles to a simple (name AS expr) used in constructing WITH clauses.
@param recursive: <description> """
and add a note about it in the NEWS file.
« Back to merge proposal
Looks good to me with the 2 points below fixed. +1
[1]
+ def __init__(self, name, select, **kwargs):
Any particular reason for not writing this as:
+ def __init__(self, name, select, recursive=False):
?
It feels more explicit to me.
[2]
Please document the new recursive parameter in the class docstring, like:
class With(Expr):
"""Compiles to a simple (name AS expr) used in constructing WITH clauses.
@param recursive: <description>
"""
and add a note about it in the NEWS file.